[binutils-gdb] Fix invalid read of section contents whilst processing a corrupt binary.

[Nick Clifton]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f055032e4e922f1e1a5e11026c7c2669fa2a7d19

commit f055032e4e922f1e1a5e11026c7c2669fa2a7d19
Author: Nick Clifton <nickc@redhat.com>
Date:   Mon Feb 13 15:04:37 2017 +0000

    Fix invalid read of section contents whilst processing a corrupt binary.
    
    	PR binutils/21135
    	* readelf.c (dump_section_as_bytes): Handle the case where
    	uncompress_section_contents returns false.

Diff:
---
 binutils/ChangeLog |  6 ++++++
 binutils/readelf.c | 16 ++++++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 10140c2..fdd5f33 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,11 @@
 2017-02-13  Nick Clifton  <nickc@redhat.com>
 
+	PR binutils/21135
+	* readelf.c (dump_section_as_bytes): Handle the case where
+	uncompress_section_contents returns false.
+
+2017-02-13  Nick Clifton  <nickc@redhat.com>
+
 	PR binutils/21149
 	* readelf.c (get_compression_header): Add size parameter.  Check
 	size against sizeof compression header before attempting to
diff --git a/binutils/readelf.c b/binutils/readelf.c
index e6f48b4..ede5747 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -12825,10 +12825,18 @@ dump_section_as_bytes (Elf_Internal_Shdr * section,
 	  new_size -= 12;
 	}
 
-      if (uncompressed_size
-	  && uncompress_section_contents (& start, uncompressed_size,
-					  & new_size))
-	section_size = new_size;
+      if (uncompressed_size)
+	{
+	  if (uncompress_section_contents (& start, uncompressed_size,
+					   & new_size))
+	    section_size = new_size;
+	  else
+	    {
+	      error (_("Unable to decompress section %s\n"),
+		     printable_section_name (section));
+	      return;
+	    }
+	}
     }
 
   if (relocate)