[binutils-gdb] Fix access violation when reporting sections that could not be dumped.

Nick Clifton nickc@sourceware.org
Mon Feb 13 14:17:00 GMT 2017


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0ee3043f58aae078a1ecc54b7be2810cae39a718

commit 0ee3043f58aae078a1ecc54b7be2810cae39a718
Author: Nick Clifton <nickc@redhat.com>
Date:   Mon Feb 13 14:17:07 2017 +0000

    Fix access violation when reporting sections that could not be dumped.
    
    	PR binutils/21147
    	* readelf.c (process_section_contents): Fix off by one error
    	reporting un-dumped sections.

Diff:
---
 binutils/ChangeLog | 6 ++++++
 binutils/readelf.c | 9 ++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 2542689..f099467 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,11 @@
 2017-02-13  Nick Clifton  <nickc@redhat.com>
 
+	PR binutils/21147
+	* readelf.c (process_section_contents): Fix off by one error
+	reporting un-dumped sections.
+
+2017-02-13  Nick Clifton  <nickc@redhat.com>
+
 	PR binutils/21139
 	* readelf.c (target_specific_reloc_handling): Add num_syms
 	parameter.  Check for symbol table overflow before accessing
diff --git a/binutils/readelf.c b/binutils/readelf.c
index de961c4..6fd7ff7 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -13172,9 +13172,12 @@ process_section_contents (FILE * file)
 
   /* Check to see if the user requested a
      dump of a section that does not exist.  */
-  while (i++ < num_dump_sects)
-    if (dump_sects[i])
-      warn (_("Section %d was not dumped because it does not exist!\n"), i);
+  while (i < num_dump_sects)
+    {
+      if (dump_sects[i])
+	warn (_("Section %d was not dumped because it does not exist!\n"), i);
+      i++;
+    }
 }
 
 static void



More information about the Binutils-cvs mailing list