[binutils-gdb] tic54x: use concat more

Trevor Saunders tbsaunde@sourceware.org
Mon May 23 05:14:00 GMT 2016


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f10e0aef4f9cb98d8c49c237ef3987f0ca3ee90f

commit f10e0aef4f9cb98d8c49c237ef3987f0ca3ee90f
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date:   Wed May 18 22:48:34 2016 -0400

    tic54x: use concat more
    
    gas/ChangeLog:
    
    2016-05-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
    
    	* config/tc-tic54x.c (tic54x_sect): simplify string creation.

Diff:
---
 gas/ChangeLog          |  4 ++++
 gas/config/tc-tic54x.c | 11 +++++------
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 6809c67..9179244 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,9 @@
 2016-05-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
 
+	* config/tc-tic54x.c (tic54x_sect): simplify string creation.
+
+2016-05-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
+
 	* config/tc-spu.c (APUOP): Use OPCODE as an unsigned constant.
 
 2016-05-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
diff --git a/gas/config/tc-tic54x.c b/gas/config/tc-tic54x.c
index 3936c97..947ba73 100644
--- a/gas/config/tc-tic54x.c
+++ b/gas/config/tc-tic54x.c
@@ -1161,28 +1161,27 @@ tic54x_sect (int arg)
     {
       char *name = NULL;
       int len;
+      /* Make sure all named initialized sections flagged properly.  If we
+         encounter instructions, we'll flag it with SEC_CODE as well.  */
+      const char *flags = ",\"w\"\n";
 
       /* If there are quotes, remove them.  */
       if (*input_line_pointer == '"')
 	{
 	  name = demand_copy_C_string (&len);
 	  demand_empty_rest_of_line ();
-	  name = strcpy (xmalloc (len + 10), name);
+	  name = concat (name, flags, (char *) NULL);
 	}
       else
 	{
 	  int c;
 
 	  c = get_symbol_name (&name);
-          len = strlen(name);
-	  name = strcpy (xmalloc (len + 10), name);
+	  name = concat (name, flags, (char *) NULL);
 	  (void) restore_line_pointer (c);
 	  demand_empty_rest_of_line ();
 	}
 
-      /* Make sure all named initialized sections flagged properly.  If we
-         encounter instructions, we'll flag it with SEC_CODE as well.  */
-      strcat (name, ",\"w\"\n");
       input_scrub_insert_line (name);
       obj_coff_section (0);



More information about the Binutils-cvs mailing list