[binutils-gdb] tc-pdp11.c: remove useless code

Trevor Saunders tbsaunde@sourceware.org
Tue Mar 22 23:11:00 GMT 2016


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=986d894b2a5484e522d540b24c0c9cf266fabacb

commit 986d894b2a5484e522d540b24c0c9cf266fabacb
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date:   Sun Mar 20 01:07:55 2016 -0400

    tc-pdp11.c: remove useless code
    
    if the condition is true then we know that str already points to a'\0' in the
    string passed to the function.  Since we know the latter part of the function
    doesn't modify that string, and str already points to a null byte there's no
    point in changing str to point to a literal empty string.
    
    gas/ChangeLog:
    
    2016-03-22  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
    
    	* config/tc-pdp11.c (md_assemble): Remove useless if and assignment to
    	str.

Diff:
---
 gas/ChangeLog         | 5 +++++
 gas/config/tc-pdp11.c | 2 --
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index a6960a22..845eacd 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
 2016-03-22  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
 
+	* config/tc-pdp11.c (md_assemble): Remove useless if and assignment to
+	str.
+
+2016-03-22  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
+
 	* config/tc-sparc.c (sparc_regname_to_dw2regnum): Replace strchr ()
 	call with a switch.
 
diff --git a/gas/config/tc-pdp11.c b/gas/config/tc-pdp11.c
index 89c75c3..f144754 100644
--- a/gas/config/tc-pdp11.c
+++ b/gas/config/tc-pdp11.c
@@ -697,8 +697,6 @@ md_assemble (char *instruction_string)
     {
     case PDP11_OPCODE_NO_OPS:
       str = skip_whitespace (str);
-      if (*str == 0)
-	str = "";
       break;
 
     case PDP11_OPCODE_IMM3:



More information about the Binutils-cvs mailing list