[binutils-gdb] MIPS/GAS/testsuite: Tighten negative-match NaN tests
Maciej W.Rozycki
macro@sourceware.org
Fri Nov 20 16:30:00 GMT 2015
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=314cf376c5b5493eeea6d3b2a357a5c832943b30
commit 314cf376c5b5493eeea6d3b2a357a5c832943b30
Author: Maciej W. Rozycki <macro@imgtec.com>
Date: Fri Nov 20 16:14:33 2015 +0000
MIPS/GAS/testsuite: Tighten negative-match NaN tests
Fix a test quality regression introduced with commit 351cdf24 [[MIPS]
Implement O32 FPXX, FP64 and FP64A ABI extensions] where MIPS ABI flags
match patterns have been added to negative-match tests covering ELF file
header flags. Negative-match tests succeed whenever there is a failure
in matching output produced and consequently the likelihood of a false
success increases when patterns to match irrelevant output are added.
Therefore remove the irrelevant paterns so that the tests complete as
soon as the line concerned has been seen.
gas/testsuite/
* gas/mips/nan-legacy-1.d: Remove MIPS ABI flags match patterns.
* gas/mips/nan-legacy-2.d: Likewise.
* gas/mips/nan-legacy-3.d: Likewise.
* gas/mips/nan-legacy-4.d: Likewise.
* gas/mips/nan-legacy-5.d: Likewise.
Diff:
---
gas/testsuite/ChangeLog | 8 ++++++++
gas/testsuite/gas/mips/nan-legacy-1.d | 15 +--------------
gas/testsuite/gas/mips/nan-legacy-2.d | 15 +--------------
gas/testsuite/gas/mips/nan-legacy-3.d | 15 +--------------
gas/testsuite/gas/mips/nan-legacy-4.d | 15 +--------------
gas/testsuite/gas/mips/nan-legacy-5.d | 15 +--------------
6 files changed, 13 insertions(+), 70 deletions(-)
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 755f619..f86cf54 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2015-11-20 Maciej W. Rozycki <macro@imgtec.com>
+
+ * gas/mips/nan-legacy-1.d: Remove MIPS ABI flags match patterns.
+ * gas/mips/nan-legacy-2.d: Likewise.
+ * gas/mips/nan-legacy-3.d: Likewise.
+ * gas/mips/nan-legacy-4.d: Likewise.
+ * gas/mips/nan-legacy-5.d: Likewise.
+
2015-11-20 Matthew Wahab <matthew.wahab@arm.com>
* gas/aarch64/virthostext-directive.d: New.
diff --git a/gas/testsuite/gas/mips/nan-legacy-1.d b/gas/testsuite/gas/mips/nan-legacy-1.d
index a2f6d0c..c13d634 100644
--- a/gas/testsuite/gas/mips/nan-legacy-1.d
+++ b/gas/testsuite/gas/mips/nan-legacy-1.d
@@ -5,17 +5,4 @@
.*:.*file format.*mips.*
#failif
private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
- None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
diff --git a/gas/testsuite/gas/mips/nan-legacy-2.d b/gas/testsuite/gas/mips/nan-legacy-2.d
index 83c559f..4a4af61 100644
--- a/gas/testsuite/gas/mips/nan-legacy-2.d
+++ b/gas/testsuite/gas/mips/nan-legacy-2.d
@@ -6,17 +6,4 @@
.*:.*file format.*mips.*
#failif
private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
- None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
diff --git a/gas/testsuite/gas/mips/nan-legacy-3.d b/gas/testsuite/gas/mips/nan-legacy-3.d
index f19d1aa..c463f2b 100644
--- a/gas/testsuite/gas/mips/nan-legacy-3.d
+++ b/gas/testsuite/gas/mips/nan-legacy-3.d
@@ -5,17 +5,4 @@
.*:.*file format.*mips.*
#failif
private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
- None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
diff --git a/gas/testsuite/gas/mips/nan-legacy-4.d b/gas/testsuite/gas/mips/nan-legacy-4.d
index c70d1d1..99c5de7 100644
--- a/gas/testsuite/gas/mips/nan-legacy-4.d
+++ b/gas/testsuite/gas/mips/nan-legacy-4.d
@@ -6,17 +6,4 @@
.*:.*file format.*mips.*
#failif
private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
- None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
diff --git a/gas/testsuite/gas/mips/nan-legacy-5.d b/gas/testsuite/gas/mips/nan-legacy-5.d
index d3b2480..b0ccb31 100644
--- a/gas/testsuite/gas/mips/nan-legacy-5.d
+++ b/gas/testsuite/gas/mips/nan-legacy-5.d
@@ -5,17 +5,4 @@
.*:.*file format.*mips.*
#failif
private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
- None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
More information about the Binutils-cvs
mailing list