[binutils-gdb/binutils-2_25-branch] Fix gold error: hidden symbol '...' is not defined locally

Alan Modra amodra@sourceware.org
Wed Mar 18 13:22:00 GMT 2015


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=20951c83ce6f1cc2823375b7523c11452d5d830f

commit 20951c83ce6f1cc2823375b7523c11452d5d830f
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Feb 18 22:36:35 2015 +1030

    Fix gold error: hidden symbol '...' is not defined locally
    
    Found when applying relocs in .debug that reference removed functions.
    
    	PR 17954
    	* powerpc.cc (Global_symbol_visitor_opd::operator()): Set default
    	visibility.

Diff:
---
 gold/ChangeLog  | 8 ++++++++
 gold/powerpc.cc | 1 +
 2 files changed, 9 insertions(+)

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 29b6f3a..4fc46e4 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,11 @@
+2015-03-18  Alan Modra  <amodra@gmail.com>
+
+	Apply from master
+	2015-02-18  Alan Modra  <amodra@gmail.com>
+	PR 17954
+	* powerpc.cc (Global_symbol_visitor_opd::operator()): Set default
+	visibility.
+
 2015-02-22  H.J. Lu  <hongjiu.lu@intel.com>
 
 	Cherry-pick from master
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index 264bbd8..9843f2f 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -6464,6 +6464,7 @@ class Global_symbol_visitor_opd
 	&& symobj->get_opd_discard(sym->value()))
       {
 	sym->set_undefined();
+	sym->set_visibility(elfcpp::STV_DEFAULT);
 	sym->set_is_defined_in_discarded_section();
 	sym->set_symtab_index(-1U);
       }



More information about the Binutils-cvs mailing list