[binutils-gdb] Fix gold error: hidden symbol '...' is not defined locally

Alan Modra amodra@sourceware.org
Wed Feb 18 12:23:00 GMT 2015


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e3ee8ed41b6a4365897d776cc181a1bd813010c6

commit e3ee8ed41b6a4365897d776cc181a1bd813010c6
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Feb 18 22:36:35 2015 +1030

    Fix gold error: hidden symbol '...' is not defined locally
    
    Found when applying relocs in .debug that reference removed functions.
    
    	PR 17954
    	* powerpc.cc (Global_symbol_visitor_opd::operator()): Set default
    	visibility.

Diff:
---
 gold/ChangeLog  | 6 ++++++
 gold/powerpc.cc | 1 +
 2 files changed, 7 insertions(+)

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 5669635..71a5ab2 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-18  Alan Modra  <amodra@gmail.com>
+
+	PR 17954
+	* powerpc.cc (Global_symbol_visitor_opd::operator()): Set default
+	visibility.
+
 2015-02-17  Rafael Ávila de Espíndola <rafael.espindola@gmail.com>
 
 	* gc.h (Garbage_collection::add_reference): Don't use find.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index ac8d05b..4deb5af 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -6551,6 +6551,7 @@ class Global_symbol_visitor_opd
 	&& symobj->get_opd_discard(sym->value()))
       {
 	sym->set_undefined();
+	sym->set_visibility(elfcpp::STV_DEFAULT);
 	sym->set_is_defined_in_discarded_section();
 	sym->set_symtab_index(-1U);
       }



More information about the Binutils-cvs mailing list