[next-over-throw2] exception_resume_breakpoint comments
Jan Kratochvil
jan.kratochvil@redhat.com
Thu Apr 29 16:47:00 GMT 2010
Hi,
on this branch I have just seen suspicious:
static void
insert_exception_resume_breakpoint (struct thread_info *tp,
struct block *b,
struct frame_info *frame,
struct symbol *sym)
- does not use TP at all.
Then clear_thread_inferior_resources now clears tp->step_resume_breakpoint.
To make tp->exception_resume_breakpoint on par with existing
tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear
even tp->exception_resume_breakpoint.
Unrelated bug is that both these breakpoints should be set as thread-specific.
Another unrelated bug is that on a thread exit thread-specific breakpoints are
not deleted (one may ask if they should be deleted, though). Fix of these two
bugs would simplify clear_thread_inferior_resources to remove even the
tp->step_resume_breakpoint handling from there.
To get back in the scope of this specific patch I would just implement:
# To make tp->exception_resume_breakpoint on par with existing
# tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear
# even tp->exception_resume_breakpoint.
Thanks,
Jan
More information about the Archer
mailing list