This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf
- From: Namhyung Kim <namhyung at gmail dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: Hemant Kumar <hemant at linux dot vnet dot ibm dot com>, linux-kernel at vger dot kernel dot org, srikar at linux dot vnet dot ibm dot com, peterz at infradead dot org, oleg at redhat dot com, hegdevasant at linux dot vnet dot ibm dot com, mingo at redhat dot com, anton at redhat dot com, systemtap at sourceware dot org, masami dot hiramatsu dot pt at hitachi dot com, aravinda at linux dot vnet dot ibm dot com, penberg at iki dot fi
- Date: Mon, 21 Jul 2014 11:38:40 +0900
- Subject: Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf
- Authentication-results: sourceware.org; auth=none
- References: <20140717054826 dot 19995 dot 61782 dot stgit at hemant-fedora> <20140717055341 dot 19995 dot 97042 dot stgit at hemant-fedora> <87d2d24kui dot fsf at tassilo dot jf dot intel dot com>
Hi Andi,
On Fri, 18 Jul 2014 10:50:45 -0700, Andi Kleen wrote:
> Hemant Kumar <hemant@linux.vnet.ibm.com> writes:
>> +/*
>> + * Finds out the libraries present in a system as shown by the command
>> + * "ldconfig --print-cache". Uses "=>" and '/' to find out the start of a
>> + * dso path.
>> + */
>
> This seems like a hack. How would that handle chroot, containers
> etc. ?
[SNIP]
>> +/*
>> + * Obtain the list of paths from the PATH env variable
>> + */
>
> Same as above. This probably needs to be more configurable to handle
> more ways to find binaries.
Agreed. What about not to be smart? IOW, just let users specify
directories and/or files to be scanned. Maybe we can use it like:
perf list sdt --scan $PATH
or
perf sdt-cache --scan /lib:/lib64
We can add some wrapper or default directory later if needed.
Thanks,
Namhyung