This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] - Fix wrong check in aux_syscalls.stp:_struct_sockaddr_u_impl (related to PR16718)
- From: David Smith <dsmith at redhat dot com>
- To: Robin Hack <rhack at redhat dot com>
- Cc: Josh Stone <jistone at redhat dot com>, systemtap at sourceware dot org
- Date: Wed, 19 Mar 2014 08:55:19 -0500
- Subject: Re: [PATCH] - Fix wrong check in aux_syscalls.stp:_struct_sockaddr_u_impl (related to PR16718)
- Authentication-results: sourceware.org; auth=none
- References: <20140318121516 dot GA5628 at bigoook dot brq dot redhat dot com> <53285F49 dot 9090806 at redhat dot com> <53287B1D dot 60002 at redhat dot com> <5328A5A5 dot 3070907 at redhat dot com> <20140319082502 dot GB9979 at bigoook dot brq dot redhat dot com>
On 03/19/2014 03:25 AM, Robin Hack wrote:
> On Tue, Mar 18, 2014 at 02:59:33PM -0500, David Smith wrote:
>> On 03/18/2014 11:58 AM, Josh Stone wrote:
>>> On 03/18/2014 07:59 AM, David Smith wrote:
>>>> size_t len = clamp((size_t)STAP_ARG_len, (size_t)0, (size_t)128);
>>>
>>> Consider using clamp_t to force a particular type.
>>
>> Ah, nice. Commit 4cddafd switches to using clamp_t.
> I dug in the kernel history and I found that clamp_t is supported from
> kernel version 2.6.26. Is this ok?
We have our own copy of clamp_t in runtine/linux/runtime.h, so we should
be OK.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)