This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v3 18/23] x86/dumpstack: Use NOKPROBE_SYMBOL macro in dumpstack.c
- From: Ingo Molnar <mingo at kernel dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-arch at vger dot kernel dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Vineet Gupta <vgupta at synopsys dot com>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, virtualization at lists dot linux-foundation dot org, Andrew Morton <akpm at linux-foundation dot org>, Ingo Molnar <mingo at redhat dot com>, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Tejun Heo <tj at kernel dot org>, Thomas Gleixner <tglx at linutronix dot de>, Jiri Slaby <jslaby at suse dot cz>, "David S. Miller" <davem at davemloft dot net>
- Date: Thu, 21 Nov 2013 12:30:06 +0100
- Subject: Re: [PATCH -tip v3 18/23] x86/dumpstack: Use NOKPROBE_SYMBOL macro in dumpstack.c
- Authentication-results: sourceware.org; auth=none
- References: <20131120042148 dot 15296 dot 88360 dot stgit at kbuild-fedora dot novalocal> <20131120042233 dot 15296 dot 31189 dot stgit at kbuild-fedora dot novalocal>
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> Use NOKPROBE_SYMBOL macro for protecting functions
> from kprobes instead of __kprobes annotation in
> dumpstack.c.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/x86/kernel/dumpstack.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Btw., all these mechanic changes of the __kprobes annotation can be
merged into a single patch. That will cut down on the size of the
series substantially.
Thanks,
Ingo