This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3 1/3] SDT markers listing by perf:
- From: Hemant Kumar <hkshaw at linux dot vnet dot ibm dot com>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-kernel at vger dot kernel dot org, srikar at linux dot vnet dot ibm dot com, peterz at infradead dot org, oleg at redhat dot com, hegdevasant at linux dot vnet dot ibm dot com, mingo at redhat dot com, anton at redhat dot com, systemtap at sourceware dot org, namhyung at kernel dot org, aravinda at linux dot vnet dot ibm dot com
- Date: Sun, 20 Oct 2013 13:17:16 +0530
- Subject: Re: [PATCH v3 1/3] SDT markers listing by perf:
- Authentication-results: sourceware.org; auth=none
- References: <20131018143714 dot 10452 dot 83494 dot stgit at hemant-fedora> <20131018144231 dot 10452 dot 65885 dot stgit at hemant-fedora> <5262A4F6 dot 3000609 at hitachi dot com>
Hi Masami,
On 10/19/2013 08:57 PM, Masami Hiramatsu wrote:
(2013/10/18 23:44), Hemant Kumar wrote:
[...]
+int show_sdt_notes(const char *target)
+{
+ int ret;
+ LIST_HEAD(sdt_notes);
+
+ ret = get_sdt_note_list(&sdt_notes, target);
+ if (!list_empty(&sdt_notes)) {
+ if (!ret)
Hmm, why don't you check the ret first? And I think the
empty check should be done in display_sdt_note_info() and
cleanup_sdt_note_list() (anyway, since both uses list_for_each*()
it is already done).
Okay, will do that.
+ display_sdt_note_info(&sdt_notes);
+ cleanup_sdt_note_list(&sdt_notes);
+ }
+ return ret;
+}
Others are good for me. :)
Great! thanks for the review. :)
--
Thanks
Hemant Kumar