This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3 2.6.39-rc1-tip 9/26] 9: uprobes: mmap and fork hooks.
- From: Peter Zijlstra <peterz at infradead dot org>
- To: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Linux-mm <linux-mm at kvack dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Jonathan Corbet <corbet at lwn dot net>, Christoph Hellwig <hch at infradead dot org>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Thomas Gleixner <tglx at linutronix dot de>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, Andi Kleen <andi at firstfloor dot org>, Andrew Morton <akpm at linux-foundation dot org>
- Date: Mon, 18 Apr 2011 18:21:57 +0200
- Subject: Re: [PATCH v3 2.6.39-rc1-tip 9/26] 9: uprobes: mmap and fork hooks.
- References: <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6> <20110401143413.15455.75831.sendpatchset@localhost6.localdomain6>
On Fri, 2011-04-01 at 20:04 +0530, Srikar Dronamraju wrote:
> + if (vma) {
> + /*
> + * We get here from uprobe_mmap() -- the case where we
> + * are trying to copy an instruction from a page that's
> + * not yet in page cache.
> + *
> + * Read page in before copy.
> + */
> + struct file *filp = vma->vm_file;
> +
> + if (!filp)
> + return -EINVAL;
> + page_cache_sync_readahead(mapping, &filp->f_ra, filp, idx, 1);
> + }
> + page = grab_cache_page(mapping, idx);
So I don't see why that isn't so for the normal install_uprobe() <-
register_uprobe() path.