This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug translator/11504] Wrong location for inferred type conflict in error message
- From: "fche at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 10 May 2010 14:33:18 -0000
- Subject: [Bug translator/11504] Wrong location for inferred type conflict in error message
- References: <20100416105207.11504.mjw@redhat.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From fche at redhat dot com 2010-05-10 14:33 -------
(In reply to comment #4)
> (In reply to comment #3)
> > The typeresolution_info::mismatch routine, basing matches on the
> > token->content fields, seems too naive, and leads to junky stuff like:
> > The core issue is that it is not tokens that get types, but expression objects.
>
> Should I add an exp_type to tokens? It wouldn't be used very often.
No, that would not make sense.
> Alternatively, we could keep an array of resolved expression objects and use
> that to check for mismatches?
That would make much more sense. Try passing/storing expression* and/or
symbol* instead of token*'s to the various resolved/invalid/mismatch()
family of functions.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11504
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.