This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v5] tracepoint: Add signal coredump tracepoint
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: Oleg Nesterov <oleg at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Roland McGrath <roland at redhat dot com>, Jason Baron <jbaron at redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, KOSAKI Motohiro <kosaki dot motohiro at jp dot fujitsu dot com>, Neil Horman <nhorman at tuxdriver dot com>
- Date: Fri, 19 Mar 2010 10:10:19 -0400
- Subject: Re: [PATCH -tip v5] tracepoint: Add signal coredump tracepoint
- References: <20100319132346.31144.40337.stgit@localhost6.localdomain6> <20100319133352.GC19394@redhat.com>
Oleg Nesterov wrote:
> (add Neil)
>
> On 03/19, Masami Hiramatsu wrote:
>>
>> void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>> {
>> struct core_state core_state;
>> - char corename[CORENAME_MAX_SIZE + 1];
>> + char corename[CORENAME_MAX_SIZE + 1] = "";
>> struct mm_struct *mm = current->mm;
>> struct linux_binfmt * binfmt;
>> struct inode * inode;
>> @@ -1802,6 +1803,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>> static atomic_t core_dump_count = ATOMIC_INIT(0);
>> struct coredump_params cprm = {
>> .signr = signr,
>> + .file = NULL,
>> .regs = regs,
>> .limit = rlimit(RLIMIT_CORE),
>> /*
>> @@ -1815,8 +1817,10 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>> audit_core_dumps(signr);
>>
>> binfmt = mm->binfmt;
>> - if (!binfmt || !binfmt->core_dump)
>> + if (!binfmt || !binfmt->core_dump) {
>> + retval = -ENOSYS;
>> goto fail;
>> + }
>
> Oh.
>
> Masami, may I ask you to delay these changes a bit?
>
> This patch conflicts very much with other changes (hopefully in -mm soon)
> we are doing.
>
> If your patch comes first, we have to redo 12 patches. Besides, this patch
> complicates do_coredump() even more while it really needs the cleanups.
Ah, that's a big conflict :O
Yes, sure, I can wait for your commits. I'll update this patch on yours.
> Please see
> http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/96f01d85034ca029/3b6bcb9b2d756dbc
> I can send you these patches privately if you wish.
OK, I can pick them up from the thread:)
Thank you!
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com