This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip tracing/kprobes] Powerpc port of the kprobe-based event tracer.
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: mahesh at linux dot vnet dot ibm dot com
- Cc: Wenji Huang <wenji dot huang at oracle dot com>, systemtap at sources dot redhat dot com
- Date: Thu, 29 Oct 2009 10:18:52 -0400
- Subject: Re: [PATCH -tip tracing/kprobes] Powerpc port of the kprobe-based event tracer.
- References: <20091020121505.724222003@mars.in.ibm.com> <4AE65F54.70800@oracle.com> <20091029051053.GA17527@in.ibm.com>
Mahesh J Salgaonkar wrote:
> On Tue, Oct 27, 2009 at 10:47:48AM +0800, Wenji Huang wrote:
>> Hi,
>>
>
> Thanks for reviewing changes. I have addressed all your suggestions.
>
>> [...]
>>> + * regs_within_kernel_stack() - check the address in the stack
>>> + * @regs: pt_regs which contains kernel stack pointer.
>>> + * @addr: address which is checked.
>>> + *
>>> + * regs_within_kenel_stack() checks @addr is within the kernel stack page(s).
>>> + * If @addr is within the kernel stack, it returns true. If not, returns false.
>>
>> s/regs_within_kenel_stack/regs_within_kernel_stack/
>> The return type function is declared as int.
>
> Changed it to bool. This code has been taken from x86 port. We may have
> to fix this there too.
Thanks Mahesh and Wenji!
Please feel free to post the x86 fix patch too :-)
>
>>> + */
>>> +
>>> +static inline int regs_within_kernel_stack(struct pt_regs *regs,
>>> + unsigned long addr)
>>> +{
>>> + return ((addr& ~(THREAD_SIZE - 1)) ==
>>> + (kernel_stack_pointer(regs)& ~(THREAD_SIZE - 1)));
>>> +}
>>> +
>>
>> Regards,
>> Wenji
>
> Please find the modified patch atached.
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Thanks!
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com