[Bug translator/10849] make MAXSKIPPED overflow trigger an error message

["chwang at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

------- Additional Comments From chwang at redhat dot com  2009-10-28 20:13 -------
Created an attachment (id=4334)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4334&action=view)
Updated patch, generated via git diff

[Message summary, if you don't want to read it all: Trying to always generate
the skipped message, no matter what other errors occur nor what the script
says]

Previous patch does not work if there is no probe end {} in the script. Created
a patch that does work with probe end.

Just adding the error messages to the appropriate places results in a println
for each skipped probe, so I used an 'atomic_read(& session_state)' and a
comparison to STAP_SESSION_ERROR to determine whether or not to print the
error.

The problem, though, is that if another error sets session state to
STAP_SESSION_ERROR, then the skipped message will not be printed. The only
error that does this is when error_count > MAXERROR -- here if we encounter
error_count > MAXERROR before skipped > MAXSKIPPED then the latter will not
print any error message.

-Charley

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10849

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.