This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
- From: Sam Ravnborg <sam at ravnborg dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, kvm <kvm at vger dot kernel dot org>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <ak at linux dot intel dot com>, Vegard Nossum <vegard dot nossum at gmail dot com>, Avi Kivity <avi at redhat dot com>, Przemys??awPawe??czyk <przemyslaw at pawelczyk dot it>
- Date: Thu, 16 Jul 2009 22:00:12 +0200
- Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
- References: <20090716155652.6266.39970.stgit@localhost.localdomain> <20090716155700.6266.71011.stgit@localhost.localdomain> <20090716163708.GB5804@merkur.ravnborg.org> <4A5F6356.9080505@redhat.com>
On Thu, Jul 16, 2009 at 01:28:54PM -0400, Masami Hiramatsu wrote:
> Sam Ravnborg wrote:
> >> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
> >> new file mode 100644
> >> index 0000000..01e079a
> >> --- /dev/null
> >> +++ b/arch/x86/include/asm/inat.h
> >> @@ -0,0 +1,125 @@
> >> +#ifndef _ASM_INAT_INAT_H
> >> +#define _ASM_INAT_INAT_H
> >
> > [With reference to comment on patch 2/12...]
> > You create inat.h here.
> > Could you investigave what is needed to factor out the stuff
> > needed from userspace so we can avoid the ugly havk where
> > you redefine types.h?
>
> Sorry, I'm a bit confusing.
> Would you mean that I should break down user_include.h and
> add those redefined types in inat.h?
No - try to factor out what is needed for your program
so you can avoid user_include.h entirely.
>
> > Maybe create a inat_types.h + inat.h as we do in other cases?
>
> And inat_types.h has two parts, one for kernel, and one for
> userspace(which is moved from user_include.h), is that right?
More like inat_types.h include pure definitions and inat.h
define all the macros (that would be much nicer if expressed
as static inlines).
The real thing to consider is what is needed from your userspace
program and is also required by the kernel.
I did not event remotely try to find out - as I guess you know it.
So try to isolate these bits somehow and you have then nicely dropped
a lot of dependencies on the remainign headers and can thus
hopefully get rid of the ugly usser_include.h hack.
Sam