This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.
- From: Josh Stone <jistone at redhat dot com>
- To: Przemyslaw Pawelczyk <przemyslaw at pawelczyk dot it>
- Cc: systemtap at sourceware dot org
- Date: Mon, 18 May 2009 17:16:58 -0700
- Subject: Re: [PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.
- References: <1242689780.410095.4911@debian>
On 05/18/2009 04:12 PM, Przemyslaw Pawelczyk wrote:
> In syscall.(faccess|fchmod|fchown|link|mknod)at probe points:
> - Rename variables accordingly to argument names used in man pages.
This much is good.
> - Remove string-formatted integer variables.
I don't agree with this part though, because those string variables are
providing a non-trivial conversion using undocumented functions
(prefixed with '_'). I think that's valuable to have, and it doesn't
hurt anything for scripts that don't use them.
Josh