This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: tapset/utrace.stp
- From: David Smith <dsmith at redhat dot com>
- To: Roland McGrath <roland at redhat dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Thu, 08 Jan 2009 13:36:57 -0600
- Subject: Re: tapset/utrace.stp
- References: <20090108082921.D773CFC3E2@magilla.sf.frob.com>
Roland McGrath wrote:
> I went to hack on a utrace API tapset to aid my kernel hacking, and I was
> surprised to find a file by that name exists.
That's mine, I believe.
> In fact, it's a file of functions magically referred used by the
> translator. (It unfortunately lacks any comments explaining that's how
> it's used.) I think it would make sense for any code that is magically
> required by the translator to be placed someplace obviously different from
> normal tapset code.
>
> Perhaps move this file to a subdirectory such as tapset/runtime/?
> (Are there any other such files?)
I'm not aware of other such files. Certainly the translator calls other
tapset functions, such as user_string() and tid().
Moving the file to a subdirectory such as tapset/runtime could be done
(which would involve modifying the session 'include_path').
Perhaps an easier solution would be to rename it, to something like
'utrace_runtime.stp' or 'utrace_internal.stp'.
Do either of the latter appeal to you? If so, I'll rename it and
comment the file a bit.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)