This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Bug: duplicate marker entry in Modules.marker
- From: Wenji Huang <wenji dot huang at oracle dot com>
- To: Roland McGrath <roland at redhat dot com>
- Cc: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>, systemtap at sources dot redhat dot com
- Date: Thu, 20 Mar 2008 17:00:10 +0800
- Subject: Re: Bug: duplicate marker entry in Modules.marker
- References: <20080320083748.3BC4B26F995@magilla.localdomain>
The marker maybe has same name, but different format.
Roland McGrath wrote:
Sorry, should have been (?):
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 695b5d6..ca8015d 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1973,7 +1973,8 @@ static void read_markers(const char *fname)
mod->skip = 1;
}
- add_marker(mod, marker, fmt);
+ if (mod->skip)
+ add_marker(mod, marker, fmt);
}
Good solution, it's OK in case of modules, but vmlinux. I just defined
marker in built-in code and changed it.
Still two entries.
I guess the above modification together with emptying the file before
run of modpost for vmlinux
will solve the problem.
Regards,
Wenji