This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 05/05] Linux Kernel Markers, non optimised architectures

From: Nick Piggin <nickpiggin at yahoo dot com dot au>
To: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
Cc: linux-kernel at vger dot kernel dot org, Linus Torvalds <torvalds at osdl dot org>, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Christoph Hellwig <hch at infradead dot org>, ltt-dev at shafik dot org, systemtap at sources dot redhat dot com, Douglas Niehaus <niehaus at eecs dot ku dot edu>, Thomas Gleixner <tglx at linutronix dot de>
Date: Fri, 12 Jan 2007 15:39:20 +1100
Subject: Re: [PATCH 05/05] Linux Kernel Markers, non optimised architectures
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:X-YMail-OSG:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=CyTSLEDc8Z1Zzc7K1ViWjrcSqdxvLkMcshdmBJlxc1xf9cVu3MFB/qlkb2ziitKNYh9iuFpvZnJjUGidsOxsGdYGkEyQ2TJxqXlpHZn6Q3LgrNHMnVUphlW9JalW45Py+dQoHubC0jxcFI/MHHsM4mg3qpcoeOtnKhHYOb+8enA= ;
References: <11685601382063-git-send-email-mathieu.desnoyers@polymtl.ca> <11685601404005-git-send-email-mathieu.desnoyers@polymtl.ca>

Mathieu Desnoyers wrote:

+#define MARK(name, format, args...) \
+	do { \
+		static marker_probe_func *__mark_call_##name = \
+					__mark_empty_function; \
+		volatile static char __marker_enable_##name = 0; \
+		static const struct __mark_marker_c __mark_c_##name \
+			__attribute__((section(".markers.c"))) = \
+			{ #name, &__mark_call_##name, format } ; \
+		static const struct __mark_marker __mark_##name \
+			__attribute__((section(".markers"))) = \
+			{ &__mark_c_##name, &__marker_enable_##name } ; \
+		asm volatile ( "" : : "i" (&__mark_##name)); \
+		__mark_check_format(format, ## args); \
+		if (unlikely(__marker_enable_##name)) { \
+			preempt_disable(); \
+			(*__mark_call_##name)(format, ## args); \
+			preempt_enable_no_resched(); \

Why not just preempt_enable() here?

-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com

Follow-Ups:
- Re: [PATCH 05/05] Linux Kernel Markers, non optimised architectures
  - From: Mathieu Desnoyers

References:
- [PATCH 00/05] Linux Kernel Markers
  - From: Mathieu Desnoyers
- [PATCH 05/05] Linux Kernel Markers, non optimised architectures
  - From: Mathieu Desnoyers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]