This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC][Patch 1/2][take3]kprobe: kprobe-booster against 2.6.15-rc5-mm3 for i386
- From: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- To: ananth at in dot ibm dot com
- Cc: maneesh at in dot ibm dot com, anil dot s dot keshavamurthy at intel dot com, systemtap at sources dot redhat dot com, Satoshi Oshima <soshima at redhat dot com>, Hideo Aoki <haoki at redhat dot com>, Yumiko Sugita <sugita at sdl dot hitachi dot co dot jp>
- Date: Tue, 24 Jan 2006 22:23:02 +0900
- Subject: Re: [RFC][Patch 1/2][take3]kprobe: kprobe-booster against 2.6.15-rc5-mm3 for i386
- References: <43AAA8EC.9070303@sdl.hitachi.co.jp> <20060124070433.GA3607@in.ibm.com>
Hi, Ananth
Ananth N Mavinakayanahalli wrote:
> On Thu, Dec 22, 2005 at 10:23:56PM +0900, Masami Hiramatsu wrote:
>
>>Hi,
>>
>>Here is a patch to clean up kprobe's resume_execute() for i386 arch.
>>Before applying kprobe-booster, I'd like to cleanup codes.
>>It is useful for simplify booster patch.
>
> Hi Masami,
>
> This patch looks fine except for some coding-style issues (^^^ below).
Thank you for review. I will fix those coding style issues.
>>+
>>+ no_change:
> ^^^^ no spaces for goto labels.
>
>
>>+ return ;
> ^^^ spurious whitespace
Then, here is OK?
---
no_change:
return;
---
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp