This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
RE: stp_exit change
- From: Martin Hunt <hunt at redhat dot com>
- To: "Mao, Bibo" <bibo dot mao at intel dot com>
- Cc: "Frank Ch. Eigler" <fche at redhat dot com>, "systemtap at sources dot redhat dot com" <systemtap at sources dot redhat dot com>
- Date: Mon, 16 Jan 2006 01:25:48 -0800
- Subject: RE: stp_exit change
- Organization: Red Hat Inc
- References: <9FBCE015AF479F46B3B410499F3AE05B08988A@pdsmsx405>
On Mon, 2006-01-16 at 12:49 +0800, Mao, Bibo wrote:
> I do not know whether we can delete atomic_set (&session_state, STAP_SESSION_STOPPING) sentence from runtime/io.c and add this sentence into file tapset/logging.stp like this:
> function exit () %{
> atomic_set (&session_state, STAP_SESSION_STOPPING);
> _stp_exit ();
> %}
That is exactly what the code did before I changed it. I was working
under the assumption that tapsets certainly shouldn't be mucking around
in translator internal state. Frank argued that he prefers that to
having the runtime do it and reverted the change back to what you have
above.
Martin