This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
- From: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>
- To: Keith Owens <kaos at sgi dot com>
- Cc: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>, Paulo Marques <pmarques at grupopie dot com>, Linux Kernel <linux-kernel at vger dot kernel dot org>, akpm at osdl dot org, tony dot luck at intel dot com, Systemtap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at us dot ibm dot com>
- Date: Tue, 10 Jan 2006 15:29:05 -0800
- Subject: Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
- References: <20060110130737.A14197@unix-os.sc.intel.com> <18641.1136934686@ocs3.ocs.com.au>
- Reply-to: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>
On Wed, Jan 11, 2006 at 10:11:26AM +1100, Keith Owens wrote:
> Keshavamurthy Anil S (on Tue, 10 Jan 2006 13:07:37 -0800) wrote:
> >On Tue, Jan 10, 2006 at 08:45:02PM +0000, Paulo Marques wrote:
> >But my [patch 2/2] speeds up the lookup and that can go in, I think.
> >Please ack that patch if you think so.
>
> Your second patch changes the behaviour of kallsyms lookup w.r.t
> duplicate symbols.
With this send patch, kallsyms lookup first finds
the real text address which is what we want. If you consider
this as the change in behaviour, what is the negetive effect of this
I am unable to get it.
In fact on arch which has the same address for 'U' and 't' type,
the search will first find the 't' type and ends the search soon,
if we have my second patch.
regards,
-Anil