This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[patch 1/4] Kprobes - Enable funcions only for required arch
- From: Anil S Keshavamurthy <anil dot s dot keshavamurthy at intel dot com>
- To: ananth at in dot ibm dot com, akpm at osdl dot org, paulmck at us dot ibm dot com
- Cc: linux-kernel at vger dot kernel dot org, systemtap at sources dot redhat dot com, Anil S Keshavamurthy <anil dot s dot keshavamurthy at intel dot com>
- Date: Tue, 13 Dec 2005 12:35:48 -0800
- Subject: [patch 1/4] Kprobes - Enable funcions only for required arch
- References: <20051213203547.649087523@csdlinux-2.jf.intel.com>
[PATCH] Kprobes - Enable funcions only for required arch
Kernel/kprobes.c defines get_insn_slot() and free_insn_slot()
which are currently required _only_ for x86_64 and powerpc (which has
no-exec support).
FYI, get{free}_insn_slot() functions manages the memory
page which is mapped as executable, required for instruction
emulation.
This patch moves those two functions under
__ARCH_WANT_KPROBES_INSN_SLOT and defines
__ARCH_WANT_KPROBES_INSN_SLOT in arch specific
kprobes.h file.
Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
------------------------------------------------------------------
include/asm-powerpc/kprobes.h | 2 ++
include/asm-x86_64/kprobes.h | 2 ++
kernel/kprobes.c | 2 ++
3 files changed, 6 insertions(+)
Index: linux-2.6.15-rc5-mm2/include/asm-powerpc/kprobes.h
===================================================================
--- linux-2.6.15-rc5-mm2.orig/include/asm-powerpc/kprobes.h
+++ linux-2.6.15-rc5-mm2/include/asm-powerpc/kprobes.h
@@ -29,6 +29,8 @@
#include <linux/ptrace.h>
#include <linux/percpu.h>
+#define __ARCH_WANT_KPROBES_INSN_SLOT
+
struct pt_regs;
typedef unsigned int kprobe_opcode_t;
Index: linux-2.6.15-rc5-mm2/include/asm-x86_64/kprobes.h
===================================================================
--- linux-2.6.15-rc5-mm2.orig/include/asm-x86_64/kprobes.h
+++ linux-2.6.15-rc5-mm2/include/asm-x86_64/kprobes.h
@@ -27,6 +27,8 @@
#include <linux/ptrace.h>
#include <linux/percpu.h>
+#define __ARCH_WANT_KPROBES_INSN_SLOT
+
struct pt_regs;
typedef u8 kprobe_opcode_t;
Index: linux-2.6.15-rc5-mm2/kernel/kprobes.c
===================================================================
--- linux-2.6.15-rc5-mm2.orig/kernel/kprobes.c
+++ linux-2.6.15-rc5-mm2/kernel/kprobes.c
@@ -52,6 +52,7 @@ static DEFINE_SPINLOCK(kprobe_lock); /*
DEFINE_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
+#ifdef __ARCH_WANT_KPROBES_INSN_SLOT
/*
* kprobe->ainsn.insn points to the copy of the instruction to be
* single-stepped. x86_64, POWER4 and above have no-exec support and
@@ -151,6 +152,7 @@ void __kprobes free_insn_slot(kprobe_opc
}
}
}
+#endif
/* We have preemption disabled.. so it is safe to use __ versions */
static inline void set_kprobe_instance(struct kprobe *kp)
--