This is the mail archive of the
systemtap@sources.redhat.com
mailing list for the systemtap project.
Re: [1/6 PATCH] Kprobes : Prevent possible race conditions generic changes
- From: Andi Kleen <ak at suse dot de>
- To: Andrew Morton <akpm at osdl dot org>
- Cc: prasanna at in dot ibm dot com, ak at suse dot de, davem at davemloft dot net,systemtap at sources dot redhat dot com, linux-kernel at vger dot kernel dot org
- Date: Thu, 7 Jul 2005 12:34:21 +0200
- Subject: Re: [1/6 PATCH] Kprobes : Prevent possible race conditions generic changes
- References: <20050707101015.GE12106@in.ibm.com> <20050707032537.7588acb9.akpm@osdl.org>
On Thu, Jul 07, 2005 at 03:25:37AM -0700, Andrew Morton wrote:
> Prasanna S Panchamukhi <prasanna@in.ibm.com> wrote:
> >
> > There are possible race conditions if probes are placed on routines within the
> > kprobes files and routines used by the kprobes.
>
> So... don't do that then? Is it likely that anyone would want to stick a
> probe on the kprobe code itself?
iirc one goal of systemtap (which uses kprobes) is to be provable
safe so that an user cannot crash the kernel by adding probes. Basically
to make it possible to use this on production systems safely. I have my
doubts they will fully reach it, but at least it's a nice goal.
> > -int register_kprobe(struct kprobe *p)
> > +static int __kprobes in_kprobes_functions(unsigned long addr)
> > +{
> > + /* Linker adds these: start and end of __kprobes functions */
> > + extern char __kprobes_text_start[], __kprobes_text_end[];
>
> There's an old unix convention that section markers (start, end, edata,
> etc) are declared `int'. For some reason we don't do that in the kernel.
> Oh well.
The Linux convention is to put it into asm-generic/sections.h at least.
-Andi