This is the mail archive of the
systemtap@sources.redhat.com
mailing list for the systemtap project.
RE: [patch 1/4] Kprobes support for IA64
- From: "Lynch, Rusty" <rusty dot lynch at intel dot com>
- To: "Keith Owens" <kaos at sgi dot com>, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>
- Cc: <akpm at osdl dot org>, "Luck, Tony" <tony dot luck at intel dot com>, "Seth, Rohit" <rohit dot seth at intel dot com>, <prasanna at in dot ibm dot com>, <ananth at in dot ibm dot com>, <systemtap at sources dot redhat dot com>, <linux-ia64 at vger dot kernel dot org>, <linux-kernel at vger dot kernel dot org>
- Date: Tue, 24 May 2005 09:20:08 -0700
- Subject: RE: [patch 1/4] Kprobes support for IA64
>From: Keith Owens [mailto:kaos@sgi.com]
>Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> wrote:
>>
>>This patch adds the kdebug die notification mechanism needed by
Kprobes.
>> case 0: /* unknown error (used by GCC for
__builtin_abort()) */
>>+ if (notify_die(DIE_BREAK, "kprobe", regs, break_num,
>TRAP_BRKPT, SIGTRAP)
>>+ == NOTIFY_STOP) {
>>+ return;
>>+ }
>> die_if_kernel("bugcheck!", regs, break_num);
>> sig = SIGILL; code = ILL_ILLOPC;
>> break;
>
>Nit pick. Any break instruction in a B slot will set break_num 0, so
>you cannot tell if the break was inserted by kprobe or by another
>debugger. Setting the string to "kprobe" is misleading here, change it
>to "break 0".
Good catch. We'll update the informational string.
--rusty