Re: [PATCH] Fix pdf build failure wrt documentation of is*_l functions

[Corinna Vinschen <vinschen at redhat dot com>]

On Aug 17 13:25, Joel Sherrill wrote:
> 
> 
> On 8/17/2016 1:13 PM, Corinna Vinschen wrote:
> > On Aug 17 11:42, Joel Sherrill wrote:
> > > 
> > > 
> > > On 8/17/2016 11:38 AM, Thomas Preudhomme wrote:
> > > > On 17/08/16 17:36, Corinna Vinschen wrote:
> > > > > Hi Thomas,
> > > > > 
> > > > > On Aug 17 17:05, Thomas Preudhomme wrote:
> > > > > > Hi Corinna,
> > > > > > 
> > > > > > make pdf on arm-none-eabi targets fails to build after the reorganization in
> > > > > > baf0c9fcb56e5cf8f54357bf8d8646b51b236886 to fold is*_l documentation in
> > > > > > their is* counterpart. This is due two issues:
> > > > > > 
> > > > > > 1) newlib/libc/ctype/ctype.tex still including the def file for the long versions
> > > > > > 2) missing angle brackets in .c files for some of is*_l functions
> > > > > > 
> > > > > > This patch fixes the issues and allows make pdf to succeeds.
> > > > > > [...]
> > > > > 
> > > > > Thanks a lot,  Especially for the ctype.tex patch which I missed
> > > > > in commit baf0c9f :}
> > > > > 
> > > > > > Is this ok for trunk?
> > > > > 
> > > > > Yes, looks good, please apply.
> > > > 
> > > > Great, but I don't have commit access. Would you mind committing for me?
> > > > 
> > > 
> > > I just tried "make info" on the master and got a lot of errors like this:
> > > 
> > > reent/signalr.def:1: warning: node prev `_kill_r' in menu `_getpid_r' and in sectioning `_sbrk_r' differ
> > > reent/signalr.def:18: warning: node next `_getpid_r' in menu `_kill_r' and in sectioning `_stat_r' differ
> > > 
> > > I did a normal configure for powerpc-rtems and then "make info". That
> > > failed with the above. I think tried a make and then make info but
> > > that failed the same way.
> > 
> > Is that *with* Thomas patch or without?
> 
> It is against the git master so I am going to say "without"

Uhm... in that case I don't quite understand the point of your reply to
a thread providing a patch to fix this issue.  Wouldn't it have made more
sense to check *with* the patch instead?!?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature