This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Define BSD u_intN_t types indiscriminately


On Mar 24 08:39, Eric Blake wrote:
> On 03/24/2016 04:08 AM, Corinna Vinschen wrote:
> > Is the below patch ok?  Glibc actually always defines u_intN_t
> > types, while we define them only on RTMES, XMK and Cygwin.
> > 
> 
> > -/* deprecated */
> > +/* BSD types, sanctioned by POSIX. */
> 
> "sanctioned" may be a bit strong; "permitted" might be better. Also,
> might be worth a note that the standard types such as uint8_t should be
> preferred; these BSD types are only provided for back-compat.
> 
> But otherwise the patch looks okay to me.

Thanks for reviewing.  I improved the comment per your suggestion.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]