This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH 5/5] Add arc4random() etc. from OpenBSD 5.8
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Fri, 18 Mar 2016 19:49:49 +0100 (CET)
- Subject: Re: [PATCH 5/5] Add arc4random() etc. from OpenBSD 5.8
- Authentication-results: sourceware.org; auth=none
- References: <1458298168-20216-1-git-send-email-sebastian dot huber at embedded-brains dot de> <1458298168-20216-6-git-send-email-sebastian dot huber at embedded-brains dot de> <20160318112828 dot GK16696 at calimero dot vinschen dot de> <20160318135001 dot GM16696 at calimero dot vinschen dot de> <56EC1522 dot 4070406 at embedded-brains dot de> <20160318162502 dot GA27115 at calimero dot vinschen dot de>
----- Am 18. Mrz 2016 um 17:25 schrieb Corinna Vinschen vinschen@redhat.com:
> On Mar 18 15:48, Sebastian Huber wrote:
>>
>>
>> On 18/03/16 14:50, Corinna Vinschen wrote:
>> >On Mar 18 12:28, Corinna Vinschen wrote:
>> >>>On Mar 18 11:49, Sebastian Huber wrote:
[...]
>> I am not sure if we should add the arc4random_stir() and
>> arc4random_addrandom() functions, since this may lead configure scripts to
>> enable their use. With the getentropy() system call I am not sure if this is
>> harmful.
>
> They are required for backward compatiblity. I also don't understand
> why they should be harmful. Are they harmful on OpenBSD?
They no longer exist on OpenBSD and were removed 2013 via this message:
"Remove arc4random_stir() and arc4random_addrandom(), which none should
be using directly. Well, a few rare people cloned it upstream and it
will take a bit of time for them to learn."
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.26&content-type=text/x-cvsweb-markup
I would move these functions to Cygwin only since they were not present in Newlib.