This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Remove broken ieeefp.h macros


On 2016-02-12 07:14, Corinna Vinschen wrote:
On Feb 11 20:27, Yaakov Selkowitz wrote:
Any attempt to use isnanf, isinff, or finitef from <ieeefp.h> on
platforms other than SPU result in a "lvalue required as unary '&'
operand" error.

	newlib/libc/
	* include/ieeefp.h (__ieeefp_isnanf): Remove broken macro.
	(__ieeefp_isinff, __ieeefp_finitef): Ditto.

This one puzzles me.  How is just removing the macros going to help,
other than avoiding a compiler warning?  Wouldn't the right thing to
do to fix the macros for GCC-5 or provide the functionality otherwise?

The macros are (supposed to be) just optimized replacements of the respective function calls. They don't compile, however, and probably didn't even before GCC 5.

--
Yaakov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]