Re: [PATCH 1/2] Fix compile with GCC 5 -Werror

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb 11 20:27, Yaakov Selkowitz wrote:
> 	newlib/libc/
> 	* stdio64/freopen64.c: Include <string.h> for memset().
> 	* stdlib/quick_exit.c: Include <unistd.h> for _exit().
> 	* string/gnu_basename.c (__gnu_basename): Fix discarded const
> 	qualifier warning.
> 	* stdlib/strtold.c: Include "mprec.h" for _strtorx_r().
> 
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
> ---
>  newlib/libc/stdio64/freopen64.c   | 1 +
>  newlib/libc/stdlib/quick_exit.c   | 1 +
>  newlib/libc/stdlib/strtold.c      | 2 ++
>  newlib/libc/string/gnu_basename.c | 2 +-
>  4 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/newlib/libc/stdio64/freopen64.c b/newlib/libc/stdio64/freopen64.c
> index 8a069d5..f7df354 100644
> --- a/newlib/libc/stdio64/freopen64.c
> +++ b/newlib/libc/stdio64/freopen64.c
> @@ -74,6 +74,7 @@ Supporting OS subroutines required: <<close>>, <<fstat>>, <<isatty>>,
>  
>  #include <time.h>
>  #include <stdio.h>
> +#include <string.h>
>  #include <errno.h>
>  #include <fcntl.h>
>  #include <stdlib.h>
> diff --git a/newlib/libc/stdlib/quick_exit.c b/newlib/libc/stdlib/quick_exit.c
> index fc43571..1d6fb23 100644
> --- a/newlib/libc/stdlib/quick_exit.c
> +++ b/newlib/libc/stdlib/quick_exit.c
> @@ -28,6 +28,7 @@
>   */
>  
>  #include <stdlib.h>
> +#include <unistd.h>
>  #include <sys/lock.h>
>  
>  /**
> diff --git a/newlib/libc/stdlib/strtold.c b/newlib/libc/stdlib/strtold.c
> index 96254eb..a6d415d 100644
> --- a/newlib/libc/stdlib/strtold.c
> +++ b/newlib/libc/stdlib/strtold.c
> @@ -30,6 +30,8 @@ POSSIBILITY OF SUCH DAMAGE.
>  
>  #include <stdlib.h>
>  #include "local.h"
> +#include "mprec.h"
> +#undef FLT_ROUNDS
>  
>  #ifdef _HAVE_LONG_DOUBLE
>  
> diff --git a/newlib/libc/string/gnu_basename.c b/newlib/libc/string/gnu_basename.c
> index 46b92d0..ca2e0e0 100644
> --- a/newlib/libc/string/gnu_basename.c
> +++ b/newlib/libc/string/gnu_basename.c
> @@ -20,7 +20,7 @@ _DEFUN (__gnu_basename, (path),
>    char *p;
>    if ((p = strrchr (path, '/')))
>      return p + 1;
> -  return path;
> +  return (char *)path;
                  ^^^
Please add a space after the closing paren.  Otherwise this patch
is ok to apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature