This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix bug in MIPS memcpy.S routine


On Jan 28 09:18, Steve Ellcey  wrote:
> Joseph Myers found a bug in my last change to the MIPS memcpy routine and has
> fixed it in glibc.  I would like to check in this patch to make the same fix
> in newlib.  The bug was in having a load instruction in the delay slot of a
> branch instruction and if the branch was taken we would end up loading a word
> beyond the end of the input being copied.  The fix is to put a register move
> in that delay slot instead since the move is harmless if the branch is taken
> and needed if the branch is not taken.
> 
> Pointer to the glibc patch and discussion:
> 
> https://sourceware.org/ml/libc-alpha/2016-01/msg00566.html
> 
> OK to checkin the same fix to newlib?

Yep.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]