This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch - Add restrict to wchar.h

On Nov 25 09:16, Joel Sherrill wrote:
> Hi
> This should be the last big patch in the add restrict series
> from Google Code-In students.
> This one is large and, although I think it is correct, there
> is plenty of room for errors. It is a fairly large but
> monotonous patch.
> As best we can tell, newlib has all the wchar.h methods
> which should have restrict added except wcsxfrm_l().
> Let me know if this is OK to commit or needs revision.

Looks good to me.  Please apply.

While we're at the end of the restrict marathon for the POSIX API, I'm
wondering if we shouldn't apply the same change to the reentrant API.

Otherwise the advantage of the restrict keyword, probably smaller and
probably faster code, is gone as soon as the the POSIX API calls the
underlying reentrant functions, and it's not available at all for
external callers of the reentrant API, isn't it?


Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpQhS_dG_Okq.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]