This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add realpath Prototype

On 11/20/2013 3:46 AM, Corinna Vinschen wrote:
> On Nov 19 12:42, Corinna Vinschen wrote:
>> On Nov 18 13:32, Joel Sherrill wrote:
>>> On 11/18/2013 12:33 PM, Yaakov (Cygwin/X) wrote:
>>>> On 2013-11-18 12:24, Joel Sherrill wrote:
>>>>> I added the realpath() prototype more or less where glibc 
>>>>> has it in stdlib.h.
>>>>> Also added restrict to Linux implementation.
>>>>> Does this look ok to commit?
>>>> Your patch includes a duplicate declaration of qsort().
>>> Fixed. Stupid cut and paste.
>>>> Also, Cygwin provides its own prototype of realpath in its 
>>>> own headers, so either that needs to be removed, or this 
>>>> prototype placed in a !__CYGWIN__ block; I'll let Corinna 
>>>> decide which she prefers.
>>> Since this wasn't in newlib, I didn't know about it. I have 
>>> been trusting grep. :)
>>> Whatever Corinna wants to do, I am ok with.
>> Just apply your patch.  I'll remove the Cygwin definition 
>> afterwards.
> FYI, I moved the readline declaration into the following `#ifndef 
> __STRICT_ANSI__' block, analogue to the old Cygwin-only 
> declaration.
Thanks. The guards are tricky. glibc has

#if defined __USE_BSD || defined __USE_XOPEN_EXTENDED
marks it as XSI with no explicit macros that I am spotting.

Is that close enough?

> Corinna

Joel Sherrill, Ph.D.             Director of Research & Development        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]