This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix NULL pointer access in getopt_internal()

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Tue, 12 Nov 2013 12:31:34 +0100
Subject: Re: [PATCH] Fix NULL pointer access in getopt_internal()
Authentication-results: sourceware.org; auth=none
References: <1384249946-17437-1-git-send-email-sebastian dot huber at embedded-brains dot de>
Reply-to: newlib at sourceware dot org

On Nov 12 10:52, Sebastian Huber wrote:
> The getopt() family functions assume a NULL terminated argument vector
> (argv).  In case the ordering is PERMUTE, then the option processing
> stops if argv[data->optind] == NULL.  Do this also for the alternative
> orderings to avoid later NULL pointer read access.
> 
> newlib/ChangeLog
> 2013-11-12  Sebastian Huber  <sebastian.huber@embedded-brains.de>
> 
> 	* libc/libc/stdlib/getopt.c (getopt_internal): Fix NULL pointer
> 	access.

Thanks, I applied a simplified version which only tests once.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpf44hpiI5fG.pgp
Description: PGP signature

Follow-Ups:
- getopt changes
  - From: Gregory Pietsch

References:
- [PATCH] Fix NULL pointer access in getopt_internal()
  - From: Sebastian Huber

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]