This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, microblaze]: Add a small Linux BSP


On Thu, Jul 25, 2013 at 08:16:51PM -0700, Michael Eager wrote:
> On 07/25/13 19:43, Edgar E. Iglesias wrote:
> >On Fri, Jul 26, 2013 at 04:10:51AM +0200, David Holsgrove wrote:
> >>>-----Original Message-----
> >>>From: Michael Eager [mailto:eager@eagerm.com]
> >>>Sent: Friday, 26 July 2013 11:43 am
> >>>To: newlib@sourceware.org; vinschen@redhat.com; David Holsgrove
> >>>Subject: Re: [Patch, microblaze]: Add a small Linux BSP
> >>>
> >>>On 07/23/13 02:11, Corinna Vinschen wrote:
> >>>>On Jul 23 17:16, David Holsgrove wrote:
> >>>>>On 23 July 2013 17:10, Corinna Vinschen <vinschen@redhat.com> wrote:
> >>>>>>On Jul 23 16:25, David Holsgrove wrote:
> >>>>>>>From: "David Holsgrove" <...>
> >>>>>>>
> >>>>>>>libgloss/ChangeLog
> >>>>>>>
> >>>>>>>2013-07-23  Edgar E. Iglesias <...>
> >>>>>>>
> >>>>>>>    * microblaze/Makefile.in: Add LINUX_BSP.
> >>>>>>>    * microblaze/elf-gloss-linux.ld: New file.
> >>>>>>>    * microblaze/elf-gloss-linux.specs: Likewise.
> >>>>>>>    * microblaze/linux-crt0.S: Likewise.
> >>>>>>>    * microblaze/linux-inbyte.c: Likewise.
> >>>>>>>    * microblaze/linux-outbyte.c: Likewise.
> >>>>>>>    * microblaze/linux-syscalls-wrap.c: Likewise.
> >>>>>>>    * microblaze/linux-syscalls.S: Likewise.
> >>>>>>>    * microblaze/linux-syscalls.h: Likewise.
> >>>>>>
> >>>>>>Please apply.
> >>>>>>
> >>>>>
> >>>>>Thanks Corinna,
> >>>>>
> >>>>>I don't have write perms on newlib - can I request them, or can you
> >>>>>apply the patch for me?
> >>>>
> >>>>Everything applied.
> >>>
> >>>This patch breaks breaks existing mb-gcc compilations.
> >>>
> >>>Please revert the patch until it can be fixed.
> >>>
> >>Hi Michael,
> >>
> >>Can you provide details regarding the breakage?
> >>
> >>This should be a separate library and not linked in by default - what sort
> >>of compilation errors are you seeing?
> >
> >
> >Hi Michael,
> >
> >Reverting the patch breaks running the GCC + binutils testsuites on QEMU-user
> >which has proven to be an extremly valuable test environment for non linux
> >targets. It also doesn't break Xilinx internal testing environment on real HW.
> >I don't know how you test, but if you can post instructions, we will be happy
> >to help with fixing the issues you are seeing.
> 
> You can't break builds in FSF-gcc, simply because it doesn't break your internal
> environment.

We are using FSF-gcc as much as anyone. We run our tests and post patches for
review. If something fails, we are happy to spend effort to fix things as long
as people post reasonable bug reports describing their test methods.

If you have a problem with this patch, please post complete instructions
on how to reproduce and we will do our best to fix what ever issue there is.
Your partial logs are unfortunately not helpful enough.


> Here is a sample test:
> mb-gcc testsuite/gcc.c-torture/execute/strcpy-1.c  -fno-diagnostics-show-caret
> -fdiagnostics-color=never  -w  -O3 -fomit-frame-pointer  -mno-xl-soft-mul
> -mxl-barrel-shift -mcpu=v6.00.a -Wl,-defsym -Wl,_HEAP_SIZE=0x1000000
> -Wl,-defsym -Wl,_STACK_SIZE=0x80000 -L microblaze_0/lib -lxil
> -TLinkScr.ld  -lm   -o strcpy-1.x3
> 
> LinkScr.ld and libxil are from either EDK9.2i or EDK-14.2.
> 
> I don't have the failure log at the moment.

To be a bit constructive and improve our chances of reproducing, a couple of questions:

Can you provide the complete error log?
What version of GCC are you using?
What version of binutils?
How did you build your toolchain?
Which libxil are you using, from 9.2 or 14.2?
 
Best regards,
Edgar



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]