This is the mail archive of the
mailing list for the newlib project.
RE: [PATCH] Fix potential reent issue
- From: "Howland Craig D (Craig)" <howland at LGSInnovations dot com>
- To: <newlib at sourceware dot org>
- Date: Mon, 24 Jun 2013 11:04:32 -0400
- Subject: RE: [PATCH] Fix potential reent issue
- References: <BLU0-SMTP2494D64FD9A74C0AB89A85FF9890 at phx dot gbl> <3862C5643B15B6468269546753EB2A9208B67D36 at BLTSXVS01 dot govsolutions dot com> <BLU0-SMTP14816884545BB05FE49DD81F98A0 at phx dot gbl>
> From: firstname.lastname@example.org [mailto:email@example.com]
On Behalf Of Federico Terraneo
> Sent: Monday, June 24, 2013 10:51 AM
> To: firstname.lastname@example.org
> Subject: Re: [PATCH] Fix potential reent issue
> It wasn't removed, it was just chained to the #if. Now, the 80 char
> per line limit in the email does not help in making the code clear,
> && !defined(__getreent) was added to the #if.
> By the way, if you tink this makes the code less clear I can provide a
> patch that nests the #ifndef inside the #if as it was before.
No, it is clear enough. I missed it when reviewing because I used a
different PC than normal and failed to notice a scrollbar to see the
of the line. Putting it into a different form might make it stand out
more, but I don't think it's worth any effort to do so.