This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] memory leak in _reclaim_reent

On Jun 24 13:10, Federico Terraneo wrote:
> Hash: SHA1
> On 06/24/2013 11:36 AM, Corinna Vinschen wrote:
> > 
> > As far as I can see, destructing _sig_func needs synchronization.
> > If you free it, a _signal_r call could come in and access the
> > free'd memory. If it already has been set to NULL, _signal_r calls
> > _init_signal_r and reallocates it.  So we either skip this problem
> > for now, or you have to make sure that nobody accesses _sig_func
> > during destruction.
> > 
> Considering that on a second though the problem looks even worse
> (malloc isn't guaranteed to by signal-safe...), I opted for a simpler
> solution.
> This patch has two advantages:
> - - it fixes the leak about _signal_buf and _misc.
> - - it leaves a comment about the _sig_func issue being unsolved, which I
>   presume is better than nothing.
> newlib/ChangeLog
> 2013-06-24  Terraneo Federico  <...>
> 	* libc/reent/reent.c (_reclaim_reent): Free also _misc and
> 	  _signal_buf.

Thanks, applied.


Corinna Vinschen
Cygwin Maintainer
Red Hat

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]