This is the mail archive of the
mailing list for the newlib project.
Re: [PATCH] Add rawmemchr
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: newlib at sourceware dot org
- Date: Mon, 24 Jun 2013 13:14:56 +0200
- Subject: Re: [PATCH] Add rawmemchr
- References: <51C7D08E dot 5090706 at users dot sourceforge dot net> <20130624094246 dot GD14427 at calimero dot vinschen dot de> <51C8270D dot 8010407 at lysator dot liu dot se>
- Reply-to: newlib at sourceware dot org
On Jun 24 13:01, Peter Rosin wrote:
> On 2013-06-24 11:42, Corinna Vinschen wrote:
> > On Jun 23 23:52, Yaakov (Cygwin/X) wrote:
> >> Code is based on memchr.c; patch for newlib attached.
> > In how far is rawmemchr different from strchr? Why don't we just alias
> > rawmemchr to strchr? Our strchr also uses an optimized search
> > algorithm, so, as far as I'm concerned, there's no reason to duplicate
> > this functionality. Am I missing something?
> See this description, which was part of the patch:
> + This function searches memory starting at <<*<[src]>>> for the
> + character <[c]>. The search only ends with the first occurrence
> + of <[c]>; in particular, <<NUL>> does not terminate the search.
> + No bounds checking is performed, so this function should only
> + be used when it is certain that the character <[c]> will be found.
Ouch, thank you. Does ENOCOFFEE qualify as excuse? I hope so...
Yaakov, please go ahead and apply, together with the patch on the