This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Move _wrapup_reent() to new file

From: Eric Blake <eblake at redhat dot com>
To: Joel Sherrill <joel dot sherrill at oarcorp dot com>
Cc: newlib at sourceware dot org
Date: Fri, 26 Apr 2013 09:09:21 -0600
Subject: Re: [PATCH] Move _wrapup_reent() to new file
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
References: <1366881156-9673-1-git-send-email-sebastian dot huber at embedded-brains dot de> <5179424D dot 8060107 at oarcorp dot com> <20130425152744 dot GG2875 at calimero dot vinschen dot de> <51794C88 dot 3070401 at oarcorp dot com> <20130425155828 dot GH2875 at calimero dot vinschen dot de> <517A94BE dot 6060200 at oarcorp dot com>

On 04/26/2013 08:52 AM, Joel Sherrill wrote:
> How about a patch like this which adds a warning comment to speak up
> and an #if 0/#endif

Idea seems sane to me.


>   *
> - *  NOTE:  This is to be executed at task exit.  It does not tear anything
> + *  NOTE:  This is to be executed at task exit.  It does not tear
> anythingkkk

Why the spurious change?

> +#endif

Is it worth making it obvious what this pairs with?
#endif /* 0 */

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Follow-Ups:
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Joel Sherrill

References:
- [PATCH] Move _wrapup_reent() to new file
  - From: Sebastian Huber
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Joel Sherrill
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Corinna Vinschen
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Joel Sherrill
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Corinna Vinschen
- Re: [PATCH] Move _wrapup_reent() to new file
  - From: Joel Sherrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]