This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Use offsetof instead of magic number in scandir()
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Thu, 28 Mar 2013 12:44:40 +0100
- Subject: Re: [PATCH] Use offsetof instead of magic number in scandir()
- References: <1364468303-7319-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20130328111705 dot GI11431 at calimero dot vinschen dot de>
On 03/28/2013 12:17 PM, Corinna Vinschen wrote:
Shouldn't we better use the upstream version as used in FreeBSD and
OpenBSD?
#define DIRSIZ(dp) \
((sizeof(struct dirent) - sizeof(dp)->d_name) + \
(((dp)->d_namlen + 1 + 3) &~ 3))
I have problems to understand this expression. What is "sizeof(dp)->d_name"?
I think this looks like a hand-crafted offsetof variant.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.