Re: libffi 3.0.9 rc4

[Samuli Suominen <ssuominen at gentoo dot org>]

On 12/24/2009 07:07 AM, Anthony Green wrote:
> Greetings...
> 
> Unless there's anything terribly wrong with the following...
> 
> ftp://sources.redhat.com/pub/libffi/libffi-3.0.9rc4.tar.gz
> 
> ...I'm going to roll it out as 3.0.9 sometime between Christmas and New
> Year (a little later than my original plan of end of November!)
> 
> I'm using quilt now, and the quilt patches are being maintained in the
> libffi git repository here: http://github.com/atgreen/libffi.  This
> makes rebasing from the GCC tree very simple.  I tried using StGit, but
> it doesn't maintain copies of the patches in the repo.  I'll update the
> libffi web page with this info once the release goes out.
> 
> Once again, please update test results here:
> http://moxielogic.org/wiki/index.php?title=Libffi_3.0.9
> 
> A big thanks to everybody who has been hacking and testing libffi!
> 
> Anthony Green

This change between rc3 and rc4 broke the include installation target,

--- libffi-3.0.9rc3/include/Makefile.am
+++ libffi-3.0.9rc4/include/Makefile.am
@@ -5,5 +5,8 @@
 DISTCLEANFILES=ffitarget.h
 EXTRA_DIST=ffi.h.in ffi_common.h

-includesdir = $(libdir)/@PACKAGE_NAME@-@PACKAGE_VERSION@/include
-nodist_includes_HEADERS = ffi.h ffitarget.h
+# Where generated headers like ffitarget.h get installed.
+gcc_version   := $(shell cat $(top_srcdir)/../gcc/BASE-VER)
+toollibffidir := $(libdir)/gcc/$(target_alias)/$(gcc_version)/include
+
+toollibffi_HEADERS = ffi.h ffitarget.h

As shown here:

unique libffi-3.0.9rc4 # ls -l /usr/lib64/gcc/x86_64-pc-linux-gnu/include/
total 16
-rw-r--r-- 1 root root 10889 Dec 24 11:28 ffi.h
-rw-r--r-- 1 root root  3496 Dec 24 11:28 ffitarget.h
unique libffi-3.0.9rc4 # pkg-config --cflags libffi
-I/usr/lib64/libffi-3.0.9rc4/include
unique libffi-3.0.9rc4 # ls -l /usr/lib64/libffi-3.0.9rc4/include
ls: cannot access /usr/lib64/libffi-3.0.9rc4/include: No such file or
directory
unique libffi-3.0.9rc4 #