This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: PATCH: Fix 64-bit libffi testsuite on Solaris 10+ (PR libffi/40700)
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: Andreas Tobler <andreast-list at fgznet dot ch>
- Cc: Andrew Haley <aph at redhat dot com>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, libffi-discuss at sourceware dot org
- Date: Sun, 20 Dec 2009 03:21:15 +0100 (CET)
- Subject: Re: PATCH: Fix 64-bit libffi testsuite on Solaris 10+ (PR libffi/40700)
- References: <yddpr6nhacf.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4B20C4D4.3000605@redhat.com> <4B2170EE.5020203@fgznet.ch>
On Thu, 10 Dec 2009, Andreas Tobler wrote:
> Anyway, there are other architectures which do have the same issue. FreeBSD,
> OpenBSD, apple-darwin10. We 'solved' this with adding the snippet below in the
> configure.ac (from the libffi sources, not in the gcc repo yet.):
>
> case "$target" in
> *-apple-darwin10* | *-*-freebsd* | *-*-openbsd*)
> AC_DEFINE(FFI_MMAP_EXEC_WRIT, 1,
> [Cannot use malloc on this target, so, we revert to
> alternative means])
> ;;
>
>
> So, my question, shall we move the three remaining OS variants into the
> closures.c file. Or should we move the solaris/x86 part from the closures.c
> file into the configure.ac part?
Are you planning on addressing this for the three platforms (Darwin,
FreeBSD, OpenBSD) for GCC 4.5? Or do we have a different fix in the
GCC tree for the time being?
Gerald