This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix libffi build on arm-linux-gnueabi with -mfloat-abi=softfp


Matthias Klose wrote:
> Based on the comments in PR41443:
> 
> All the references to __SOFTFP__ in this file are incorrect for EABI; the
> __SOFTFP__ code should be used for *soft-float ABI* whether or not VFP is
> enabled, and __SOFTFP__ does specifically mean soft-float not soft-float
> ABI.
> 
> If you change the conditionals to __SOFTFP__ || __ARM_EABI__ then
> -mfloat-abi=softfp should work.  -mfloat-abi=hard won't; that would need
> both a new macro to identify the hard-VFP ABI, and new libffi code to
> handle that ABI.
> 
> No regressions when running the libffi testsuite with and without
> -mfloat-abi=softfp.
> 
> Ok for the trunk, ok for the branches (checking that the macros are
> available there)?

Yes, I think that's the right thing to do.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]