This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [Patch] RFE new API - gettimezone
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: P J P <pj dot pandit at yahoo dot co dot in>
- Cc: "libc-help at sourceware dot org" <libc-help at sourceware dot org>
- Date: Wed, 2 Apr 2014 19:22:09 +0530
- Subject: Re: [Patch] RFE new API - gettimezone
- Authentication-results: sourceware.org; auth=none
- References: <1396378055 dot 16229 dot YahooMailNeo at web192405 dot mail dot sg3 dot yahoo dot com> <1396444446 dot 15012 dot YahooMailNeo at web192402 dot mail dot sg3 dot yahoo dot com>
On 2 April 2014 18:44, P J P <pj.pandit@yahoo.co.in> wrote:
> Hello,
>
> WRT BZ#1077902 [1], please find attached herein, a patch to add the new API - gettimezone(),
> which returns local time zone information in the form of a POSIX TZ environment variable string.
> The API reads the '/etc/localtime' file to fetch the said information.
>
> Could someone please help me with the patch review and other comments that could be helpful for the development of this API.
> --
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1077902#c2
Hey PJP,
Patches go to libc-alpha at sourceware dot org, this mailing list is
for general questions. You might want to take a look at the
contribution checklist:
http://sourceware.org/glibc/wiki/Contribution%20checklist
Also, you might want to post the patch inline rather than as an
attachment since it makes reviews easier.
Finally, I took a quick look at the patch and it looks like more of an
independent program to demo a function rather than something that
actually builds into glibc. There are several other changes you'll
need to change to get there, like:
- Avoid using the hardcoded strings and use those defined in glibc instead
- Modifying time/Makefile to get gettimezone to build.
- Adding a symbol to time/Versions to export a symbol for gettimezone.
Siddhesh
--
http://siddhesh.in