This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid preprocessor FALLOC_FL_* token redefinitions


On 7 January 2014 18:40, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 01 January 2014 17:15:10 Sami Kerola wrote:
>> The linux/falloc.h header defines both FALLOC_FL_KEEP_SIZE and
>> FALLOC_FL_PUNCH_HOLE.
>
> this is not how we want to protect collisions between the kernel headers and
> the C library.  see the recent threads on net/ptrace/xattrs headers instead.
>
> even all that said, unless you're calling the fallocate syscall directly, you
> shouldn't be including linux/falloc.h.  if you're using using the C library's
> fallocate() function, you need to only use the C library's headers.

Hi Mike,

Got it. If anyone ever finds this thread the application change discussion can
be found from util-linux maillist archive.

http://www.spinics.net/lists/util-linux-ng/index.html#08707

-- 
Sami Kerola
http://www.iki.fi/kerolasa/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]