This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix spelling in memusagestat.c


Holger,

Please review the contribution checklist.
http://sourceware.org/glibc/wiki/Contribution%20checklist

> 2009-10-30 ?Holger Hans Peter Freyther <zecke@selfish.org>

Two spaces after name between email.

> ? ? ? ?* malloc/memusagestat.c (main): Fix spelling in an error message.

Tab not spaces.

Example:
YYYY-MM-DD<2 spaces>John Doe<2 spaces><johndoe@some.email.address>
<blank-line>
<tab--->[BZ <number]<use this if there is a bugzilla associated with the patch>
<tab--->* login/utmp_file.c (pututline_file): replace call to
'dup()'<line wrap at or before column 80>
<tab--->with libc internal symbol '__dup()' to avoid access
through<line wrap at or before column 80>
<tab--->the PLT.

> ---
> ?malloc/memusagestat.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/malloc/memusagestat.c b/malloc/memusagestat.c
> index 4d57f2c..a5a3150 100644
> --- a/malloc/memusagestat.c
> +++ b/malloc/memusagestat.c
> @@ -181,7 +181,7 @@ main (int argc, char *argv[])
> ? ? ? || st.st_size < 2 * sizeof (struct entry))
> ? ? {
> ? ? ? close (fd);
> - ? ? ?error (EXIT_FAILURE, 0, "input file as incorrect size");
> + ? ? ?error (EXIT_FAILURE, 0, "input file has incorrect size");
> ? ? }
> ? /* Compute number of data entries. ?*/
> ? total = st.st_size / sizeof (struct entry) - 2;
> --
> 1.6.3.3

Otherwise this looks good.

Please resubmit this to libc-alpha, or file it as a bug in the
bugzilla. I recommend filing it in the bugzilla.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]