This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: Need help in properly formatting a patch for glibc
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Denys Vlasenko" <dvlasenk at redhat dot com>
- Cc: "Ryan Arnold" <ryan dot arnold at gmail dot com>, libc-help at sourceware dot org
- Date: Tue, 19 Aug 2008 08:20:50 -0400
- Subject: Re: Need help in properly formatting a patch for glibc
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=H1zlQ4gUKeezZwh6qdxgntoua0W7+6I4FBi29TReeHI=; b=r39LPmNwFhyWbQ5LD1DDP3a57/HR8uGPdGOoMshJmPbnJWrAvs06Zw9U/4YlCLPdwk ZjWrlHfpIy9465LLUKJNlCaiVKdsu5iI7hqzlxM4SXKtiZEuDSzwlF33hhBgbyvgPU8L smnlQ9rxkMJSKquxw86Lq46WQBoGyEawRSaiw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=DwfNI8QMDrQaEiHuV47JvrUKuPxBl/xohkPhdE/iX8dRLB9q6V6908/mlDGkcxatlb 6rlLGSRo2s3zL0wFaEVg/070TnAKc/nSmDYRQ1Ik2KM8FWO4eXiKC4SOHSHdPiOyEkZT oDMtrDsL2d+kCu1YgsN6Idj6IIKJ9zR7vxG5E=
- References: <1219073537.13567.11.camel@localhost.localdomain> <ff4da150808180842v31c37d79j9669efe5182b1ce@mail.gmail.com> <119aab440808181228l6bb26d3end40502cddd77050e@mail.gmail.com> <1219136250.3333.3.camel@localhost.localdomain>
On Tue, Aug 19, 2008 at 4:57 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> On Mon, 2008-08-18 at 15:28 -0400, Carlos O'Donell wrote:
>> On Mon, Aug 18, 2008 at 11:42 AM, Ryan Arnold <ryan.arnold@gmail.com> wrote:
>> > On Mon, Aug 18, 2008 at 10:32 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>> >> Please advice what I did wrong, and what is the correct Changelog
>> >> format.
>>
>> Your patch also lacks the following:
>>
>> 1. A detailed explanation of the patch.
>> e.g. Under what conditions does it occur?
>
> Details are at https://bugzilla.redhat.com/show_bug.cgi?id=457508
It is customary to repeat some of the important details *and* include
a reference.
Please remember that we are all volunteers. You have to make it easy
for us to give you an "A+" on your bug report and patch.
Adding a summary of the relevant details helps give you an "A+"
>> 2. Testing.
>> e.g. After patching glibc, did you run the testsuite to verify your
>> patch didn't break anything?
>
> Yes, it does not break anything.
Excellent. It's important that you state something like "No
regressions on $target" where $target is the system on which you ran
the glibc testsuite. This shows the developers that you checked to see
if your patch caused regressions.
Cheers,
Carlos.